[FFmpeg-devel] [PATCH] Apple RPZA encoder

[Diego Biurrun]

On Tue, Mar 24, 2009 at 05:05:12PM +0530, Jai Menon wrote:
> On 3/24/09, Diego Biurrun <diego at biurrun.de> wrote:
> > On Tue, Mar 24, 2009 at 02:08:44PM +0530, Jai Menon wrote:
> >  > On 3/24/09, Diego Biurrun <diego at biurrun.de> wrote:
> >  > > On Tue, Mar 24, 2009 at 10:33:19AM +0530, Jai Menon wrote:
> >  > >  > +    bi.image_width = s->frame_width;
> >  > >  > +    bi.image_height = s->frame_height;
> >  > >  > +    bi.rowstride = pict->linesize[0];
> >  > >  > +
> >  > >  > +    bi.blocks_per_row = (s->frame_width + 3) >> 2;
> >  > >
> >  > >  align
> >  >
> >  > aligned
> >
> > But many more opportunities for alignment exist throughout your patch..
> 
> IMHO alignment is only of concern if the code is unreadable without
> the extra cosmetic spaces.

Do you disagree that it it more readable aligned?

> I feel that the code right now is quite readable. If you feel
> otherwise, please mention the relevant section of the hunk.

My goal is to avoid exactly that.  You should fix such issues on your
own without need for somebody to point you at every single case.

Michael will relentlessly point them out to you anyway.  It's better to
address such issues up front, take load from Michael and get you patch
merged quicker.

Diego