[FFmpeg-devel] [PATCH] Apple RPZA encoder
Mon Mar 30 07:50:26 CEST 2009
On 3/30/09, Diego Biurrun <diego at biurrun.de> wrote:
> On Mon, Mar 30, 2009 at 10:17:43AM +0530, Jai Menon wrote:
> > Other fixes were made, patch attached.
> > --- libavcodec/Makefile (revision 18140)
> > +++ libavcodec/Makefile (working copy)
> > @@ -182,6 +182,7 @@
> > OBJS-$(CONFIG_RPZA_DECODER) += rpza.o
> > +OBJS-$(CONFIG_RPZA_ENCODER) += rpzaenc.o
> Does this really depend on nothing else? Try disabling all decoders and
> encoders and just enabling rpzaenc.
I will see if it builds in that case but why do you suspect this. I'm
not making use of any shared code or anything else for that matter.
> > --- libavcodec/rpzaenc.c (revision 0)
> > +++ libavcodec/rpzaenc.c (revision 0)
> > @@ -0,0 +1,746 @@
> > +/*
> > + * QuickTime RPZA video encoder.
> pointless period
> I don't want to bitch about this, but please use proper punctuation in
> your doxygen comments.
Sorry, My grammar is not upto snuff :) . I'll do a round of such
cleanups after michael's review. That way I can roll most changes into
a single patch.
More information about the ffmpeg-devel