[FFmpeg-devel] some renames in the regression testsuite

Baptiste Coudurier baptiste.coudurier
Mon Mar 30 22:20:09 CEST 2009

On 3/30/2009 12:38 PM, Michael Niedermayer wrote:
> On Mon, Mar 30, 2009 at 12:04:34PM -0700, Baptiste Coudurier wrote:
>> On 3/30/2009 10:17 AM, Michael Niedermayer wrote:
>>> On Mon, Mar 30, 2009 at 05:59:44PM +0100, M?ns Rullg?rd wrote:
>>>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>>>>> On Mon, Mar 30, 2009 at 05:32:18PM +0200, Diego Biurrun wrote:
>>>>>> On Mon, Mar 30, 2009 at 03:54:32PM +0200, Reimar D?ffinger wrote:
>>>>>>> On Mon, Mar 30, 2009 at 02:22:46PM +0200, Diego Biurrun wrote:
>>>>>>>> Those changes are done.  Next I wanted to change the filenames of the
>>>>>>>> generated regression files to use lavf instead of libav, but when I
>>>>>>>> apply the attached patch, the lavftest target fails with a difference
>>>>>>>> during the gxf test.  I'm completely puzzled, all this does is rename
>>>>>>>> a few files, how can this affect the result?
>>>>>>> Upload the two gxf files (assuming they differ).
>>>>>> I have uploaded a dir named 'regtest_fail_file_rename' with 'before' and
>>>>>> 'after' subdirectories to incoming.
>>>>> gxf_write_material_data_section writes the file name into the output.
>>>> WTF is that supposed to be good for?
>>> i agree this is sick, i can only imagine this to leak info the user is not
>>> aware of (even we wherent aware of it ...)

I was aware of it, as the maintainer.

>> Like libavformat version by default ? Is the user aware of this ?
>> Almost every muxer is already leaking this information....
> the user probably isnt but the lavf version is at least usefull
> just look at how many divx&xvid version checks we have in our mpeg4
> decoder to workaround bugs. And our lavf isnt bugfree either ...

Of course. My point is that having information in the file is not always
"sick" like you pointed.

Is the basename of the filename(execpt on win32 it seems) harmful to
have ? I don't think so.
Some files like reference files are used which contain either the full
path (which leaks the directory structure as well), in mov and mxf at least.

For now just update the regression ref.

Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org

More information about the ffmpeg-devel mailing list