[FFmpeg-devel] [Fwd: Summer of code small task patch]

[Michael Niedermayer]

On Tue, Mar 31, 2009 at 10:50:25AM +0200, Dylan Yudaken wrote:
>
>
> Diego Biurrun wrote:
>> On Tue, Mar 31, 2009 at 08:52:30AM +0200, Dylan Yudaken wrote:
>>   
>>> --- a/libavcodec/dct-test.c
>>> +++ b/libavcodec/dct-test.c
>>>     
>>
>> I dunno how you created this patch, but it seems you did not use
>> mechanical search and replace - bad idea, some typos crept in.
>>   
>
> very annoying that. sorry. it was only under processors I dont use
>>   
>>> --- a/libavcodec/dct-test.c
>>> +++ b/libavcodec/dct-test.c
>>> @@ -90,57 +90,57 @@ struct algo {
>>>   #if HAVE_ALTIVEC
>>> -  {"altivecfdct",     0, fdct_altivec,       fdct, NO_PERM, 
>>> FF_MM_ALTIVEC},
>>> +  {"altivecfdct",     0, fdct_altivec,       ff_ref_dct, NO_PERM, 
>>> FF_MM_ALTIVEC},
>>>     
>>
>> typo
>>
>>   
>>>  #if ARCH_ALPHA
>>> -  {"SIMPLE-ALPHA",    1, ff_simple_idct_axp,  idct, NO_PERM },
>>> +  {"SIMPLE-ALPHA",    1, ff_simple_idct_axp,  ref_idct, NO_PERM },
>>>     
>>
>> another typo
>>
>> Diego
>>
>> P.S.: Dylan, your patches have mime-type application/mbox, this is weird
>> and not helpful when trying to view patches inline.
>>   
>
> hmm, I was using git-format-patch. these were attached using git-diff.
>

patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090331/fcfdbcd0/attachment.pgp>