[FFmpeg-devel] [PATCH] fix warnings in tree.c test

Benoit Fouet benoit.fouet
Tue Mar 31 16:00:17 CEST 2009


On 03/31/2009 03:49 PM, Michael Niedermayer wrote:
> On Tue, Mar 31, 2009 at 02:47:19PM +0200, Benoit Fouet wrote:
>   
>> Hi,
>>
>> On 03/31/2009 02:35 PM, Michael Niedermayer wrote:
>>     
>>> On Tue, Mar 31, 2009 at 09:47:17AM +0200, Benoit Fouet wrote:
>>>   
>>>       
>>>> Hi,
>>>>
>>>> attached patch to $subj:
>>>> libavutil/tree.c: In function ?print?:
>>>> libavutil/tree.c:170: warning: format ?%4d? expects type ?int?, but
>>>> argument 6 has type ?void *?
>>>> libavutil/tree.c: In function ?cmp?:
>>>> libavutil/tree.c:178: warning: pointer of type ?void *? used in subtraction
>>>> libavutil/tree.c: In function ?main?:
>>>> libavutil/tree.c:198: warning: passing argument 3 of ?av_tree_insert?
>>>> from incompatible pointer type
>>>> libavutil/tree.c:204: warning: passing argument 3 of ?av_tree_insert?
>>>> from incompatible pointer type
>>>> libavutil/tree.c:205: warning: passing argument 3 of ?av_tree_find? from
>>>> incompatible pointer type
>>>> libavutil/tree.c:205: warning: assignment makes integer from pointer
>>>> without a cast
>>>>     
>>>>         
>>> patch ok if tested
>>>
>>> [...]
>>>   
>>>   
>>>       
>> my sequence to test it:
>> $ svn di libavutil/tree.c > tree.c.diff
>> $ svn revert libavutil/tree.c
>> $ make libavutil/tree-test
>> $ ./libavutil/tree-test > before 2>&1
>> $ patch -p0 -i tree.c.diff
>> $ make libavutil/tree-test
>> $ ./libavutil/tree-test > after 2>&1
>> $ cmp before after && echo ok
>> ok
>>
>> is that enough to test it ?
>>     
>
> yes
>
> [...]
>
>   

applied then

Ben




More information about the ffmpeg-devel mailing list