[FFmpeg-devel] skip_put_bits() bugged?

Stefano Sabatini stefano.sabatini-lala
Tue Mar 31 21:36:27 CEST 2009


On date Tuesday 2009-03-31 20:44:34 +0200, Michael Niedermayer encoded:
> On Tue, Mar 31, 2009 at 08:15:15PM +0200, Stefano Sabatini wrote:
[...]
> > My previous fix adds a check, so it slows down it a little, but I
> > don't see other alternatives but to change the other functions (such
> > as put_bits() to make bit_left only take values less than 32.
> 
> i dont see any bug that you fix i just see a slowdown you create,
> if there is a bug id like to see full ffmpeg output from an unmodified ffmpeg

Uh, looks like you're right.

Patch attached, regards.
-- 
FFmpeg = Friendly Fundamentalist Mean Patchable Ecletic Gadget
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-skip-put-bits-docs.patch
Type: text/x-diff
Size: 458 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090331/2b34d4d9/attachment.patch>



More information about the ffmpeg-devel mailing list