[FFmpeg-devel] [PATCH] yuv2rgb: Trailing pixels are not converted if destination width is not multiple of 4

Cédric Schieli cschieli
Fri May 1 10:07:49 CEST 2009

2009/4/30 Michael Niedermayer <michaelni at gmx.at>:
> On Thu, Apr 30, 2009 at 09:45:31PM +0200, C?dric Schieli wrote:
>> 2009/4/30 Michael Niedermayer <michaelni at gmx.at>:
>> > On Mon, Apr 27, 2009 at 04:08:13PM +0200, C?dric Schieli wrote:
> [...]
>> > besides i dont see how it could even work, it still has to be a multiple
>> > of 2.
>> yes, but ffmpeg do not accept an odd destination width anyway.
> thats a very lame excuse, not all files are generated by ffmpeg and the
> check might be removed

I know, that's why
>> I'm ok it would be better to find a full fix

>> >
>> > also was this bug always existing or is it new since the yuv2rgb rewrite?
>> I did not test, but a quick look at the old yuv2rgb.c makes me think
>> it was already there
> until its confirmed that the old code was buggy too i think we should
> refrain from adding bloat, maybe it used a simpler fix

I can now confirm the bug was already there with the old code (tested
with a -r{2009-02-21} checkout of both ffmpeg and libswscale).

The only way I can think of (for the moment) to remove the bloat would
impair performance, so maybe we should have both ways and use
CONFIG_SMALL to choose ?


More information about the ffmpeg-devel mailing list