[FFmpeg-devel] [PATCH] Implement av_get_token()
Fri May 1 13:33:09 CEST 2009
On date Thursday 2009-04-30 03:45:13 +0200, Michael Niedermayer encoded:
> On Sat, Apr 25, 2009 at 01:21:49PM +0200, Stefano Sabatini wrote:
> > > add \ at the end escaing the traiing null
> > > and unterminated '
> > > and escaped leading and trailing whitespace
> > OK.
> > [..]
> > > > + /* strip trailing whitespaces */
> > > > + out--;
> > > > + while(--out >= ret && strspn(out, WHITESPACES))
> > > > + *out = 0;
> > >
> > > this will remove escaped trailing whitespaces
> > Reimplemeneted as a finite state machine, as the previous apporach was
> > resulting messy and unreadable.
> i do not plan to approve this patch
> i think work should continue based on the previous version
> which was cleaner, simpler and smaller
> it only had one trivial bug
The previous patch had more problems that it looked, especially for
which regarded the terminating condition which I'm explicitely setting
now (for this I'm using the is_end var).
Other than this, the attached patch is absolutely equivalent to the
previous one in term of functionality (and now that I look at it I may
agree it's nicer).
BTW: should I keep also the test when committing?
FFmpeg = Fundamentalist Faboulous Merciful Philosophical Embarassing Guide
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5723 bytes
Desc: not available
More information about the ffmpeg-devel