[FFmpeg-devel] [PATCH] Added integer 32 bits support to wavpack

Reimar Döffinger Reimar.Doeffinger
Fri May 1 20:28:31 CEST 2009

On Fri, May 01, 2009 at 07:39:37PM +0300, Kostya wrote:
> On Fri, May 01, 2009 at 06:08:37PM +0200, Laurent Aimar wrote:
> > > I'd use s->crc_extra = AV_RL32(buf) and open bit buffer after that but this
> > > looks fine too. Oh, and please add block size check.
> >  Using the bitstream reader here seems simpler to me, and additionnaly 
> > avoid the need of buffer size checks ;)
> It's not - if size <=4 (as WavPack source code says), it should be treated as
> error, so check is needed anyway (not for bits reading though).

Huh? Where does that idea that using the bitstream reader means you can
skip the size checks come from?
Is that why ALAC is so horribly broken in that regard?
Where to we need to put the large over-size warning sign so we do not
get more of a mess based on wrong assumptions?

More information about the ffmpeg-devel mailing list