[FFmpeg-devel] [PATCH] lavfi documentation nits
Diego Biurrun
diego
Tue May 5 01:02:06 CEST 2009
On Mon, May 04, 2009 at 10:39:56PM +0200, Stefano Sabatini wrote:
> On date Monday 2009-05-04 22:26:27 +0200, Diego Biurrun encoded:
> > On Mon, May 04, 2009 at 10:07:13PM +0200, Stefano Sabatini wrote:
> > > On date Monday 2009-05-04 22:01:44 +0200, Diego Biurrun encoded:
> > > > On Mon, May 04, 2009 at 09:29:34PM +0200, Stefano Sabatini wrote:
> > > > > On date Monday 2009-05-04 10:10:25 +0200, Diego Biurrun encoded:
> > > > > > On Sun, May 03, 2009 at 11:12:08PM +0200, Stefano Sabatini wrote:
> > > > > > >
> > > > > > > prefer third person over first person, and use just one space between
> > > > > > > a sentence and the following one, also removes \p.
> > > > > > > Consistent with the rest of FFmpeg.
> > > > > >
> > > > > > This contains some whitespace-only changes and variable renamings.
> > > > >
> > > > > Sorry, please check again.
> > > >
> > > > Still contains whitespace-only changes.
> > >
> > > Yes and those changes are intentional (read above). Are you suggesting
> > > to split whitespace changes apart from the other ones (as for me they
> > > could also stay in the same patch)?
> >
> > Michael will rip your still-beating heart out if you don't.
>
> Eheh. Patch updated, if OK I'll apply as a separate patch the
> whitespace changes.
..
> --- libavfilter/avfilter.h (revision 18726)
> +++ libavfilter/avfilter.h (working copy)
> @@ -112,7 +112,7 @@
>
> /**
> - * Remove a reference to a picture. If this is the last reference to the
> + * Removes a reference to a picture. If this is the last reference to the
There is little point in keeping the two spaces on lines you already
change...
> @@ -518,7 +518,7 @@
>
> /**
> - * Notify the next filter of the start of a frame.
> + * Notifies the next filter of the start of a frame.
notify about
> --- libavfilter/avfiltergraph.h (revision 18726)
> +++ libavfilter/avfiltergraph.h (working copy)
> @@ -32,7 +32,7 @@
> } AVFilterGraph;
>
> /**
> - * Get from \p graph a filter instance with name \p name.
> + * Gets from graph a filter instance with name name.
Gets a filter instance with name name from graph.
Diego
More information about the ffmpeg-devel
mailing list