[FFmpeg-devel] [PATCH] Warning fix: data parameter of AVCodec.encode is not const

Baptiste Coudurier baptiste.coudurier
Wed May 6 23:05:14 CEST 2009


Hi,

Daniel Verkamp wrote:
> [...]
>
>  }
>  
> -static int dnxhd_encode_picture(AVCodecContext *avctx, unsigned char *buf, int buf_size, const void *data)
> +static int dnxhd_encode_picture(AVCodecContext *avctx, unsigned char *buf, int buf_size, void *data)
>  {
>      DNXHDEncContext *ctx = avctx->priv_data;
>      int first_field = 1;
> 

Well, I've no objection to the patch for the sake of removing warnings,
however I think this parameter is right to be const, that's input picture.

Maybe encode prototype should be changed instead.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org



More information about the ffmpeg-devel mailing list