[FFmpeg-devel] [PATCH] Fix for inverted sign in ffvorbis audio output (resubmit)

Reimar Döffinger Reimar.Doeffinger
Sun May 10 14:11:04 CEST 2009

On Sun, May 10, 2009 at 12:38:17PM +0300, Siarhei Siamashka wrote:
> This set of patches has been already OK'ed, but then was lost:
> https://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2008-October/054266.html

Who OK'd id? The ff_mdct_init change contains cosmetics and pointless code
Also almost everyone uses a scale factor of 1, except vorbis, wouldn't
it possibly make more sense to instead add a ff_mdct_init_scaled with the
scale and leave the rest unchanged? I don't really know, just thinking.
I also wonder if it might be better if the calling code did the sqrt(),
for the current uses doing it in ff_mdct_init seems like it would only
add pointless complexity and possibly inaccuracies (or is e.g. sqrt(1.0) ==
1.0 always guaranteed by the C standard?).

More information about the ffmpeg-devel mailing list