[FFmpeg-devel] [PATCH] V210 decoder and encoder

Michael Niedermayer michaelni
Tue May 12 01:27:16 CEST 2009


On Mon, May 11, 2009 at 01:53:25PM -0700, Baptiste Coudurier wrote:
> On 5/11/2009 1:44 PM, Michael Niedermayer wrote:
> > On Mon, May 11, 2009 at 12:40:08PM -0700, Baptiste Coudurier wrote:
> >> On 5/11/2009 12:21 PM, Michael Niedermayer wrote:
> >>> On Sat, May 09, 2009 at 01:30:40PM -0700, Baptiste Coudurier wrote:
> >>>> Hi
> >>>>
> >>>> $subject.
> >>>>
> >>>> -- 
> >>>> Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
> >>>> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> >>>> FFmpeg maintainer                                  http://www.ffmpeg.org
> >>>>  Changelog              |    1 
> >>>>  libavcodec/Makefile    |    2 
> >>>>  libavcodec/allcodecs.c |   15 ++
> >>>>  libavcodec/avcodec.h   |    3 
> >>>>  libavcodec/v210.c      |  258 +++++++++++++++++++++++++++++++++++++++++++++++++
> >>>>  5 files changed, 278 insertions(+), 1 deletion(-)
> >>>> 164b26551774be7306c36786b5af2f1aeb7e771f  v210.patch
> >>> [...]
> >>>> +#if CONFIG_V210_ENCODER
> >>>> +static av_cold int encode_init(AVCodecContext *avctx)
> >>>> +{
> >>>> +    if (avctx->width & 1) {
> >>>> +        av_log(avctx, AV_LOG_ERROR, "v210 needs even width\n");
> >>>> +        return -1;
> >>>> +    }
> >>>> +
> >>>> +    if (avctx->pix_fmt != PIX_FMT_YUV422P16 ||
> >>>> +        avctx->bits_per_raw_sample != 10) {
> >>>> +        av_log(avctx, AV_LOG_ERROR, "v210 needs YUV 4:2:2 10bit\n");
> >>> i wonder if this is not a little too strict ...
> >> What do you think of ?
> >> v210 requires this, it only stores 10bits.
> > 
> > yes but it also happily stores 10 if there where 9 or 12 if that
> > check wouldnt be there ...
> 
> If you think it's safe, I can remove the check. Do you want me to remove
> it completely ?

I think a warning could be printed ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090512/56fe1186/attachment.pgp>



More information about the ffmpeg-devel mailing list