[FFmpeg-devel] [PATCH][RFC] variable frame sizes

Michael Niedermayer michaelni
Fri May 15 12:49:13 CEST 2009


On Thu, May 14, 2009 at 04:04:57PM -0700, Eric Buehl wrote:
> Hello,
> 
> I submitted a bug a while back describing ffmpeg's failure to account for
> varying frame sizes in a single file.
> http://roundup.ffmpeg.org/roundup/ffmpeg/issue879  I have confirmed that the
> sample referenced works as expected in mplayer so I do not believe it is a
> problem with lavc/lavf.

>  Attached is a patch that works for frames of
> varying height (possible if interlacing options are mis-used) but it does
> not account for changes in width.

so its incomplete ...

[...]

>  ffmpeg.c |   20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 726f5c891ba925ffb00806f43c935696105872ef  dynamic_frame_height_adjust.patch
> Index: ffmpeg.c
> ===================================================================
> --- ffmpeg.c	(revision 18831)
> +++ ffmpeg.c	(working copy)
> @@ -923,6 +923,26 @@
>      if (ost->video_resample) {
>          padding_src = NULL;
>          final_picture = &ost->pict_tmp;
> +	if(ost->resample_height != ist->st->codec->height)

tabs and as this is under if (ost->video_resample)
i wonder if it works if thats false to begin with ...


> +        {

inconsistant { placement

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090515/3c888eb5/attachment.pgp>



More information about the ffmpeg-devel mailing list