[FFmpeg-devel] [PATCH] Move MLP's dot product to DSPContext

Ramiro Polla ramiro.polla
Fri May 15 15:38:01 CEST 2009


Hi,

On Fri, May 15, 2009 at 5:49 AM, Diego Biurrun <diego at biurrun.de> wrote:
> On Thu, May 14, 2009 at 07:44:36PM -0300, Ramiro Polla wrote:
>>
>> /*
>> ?* Copyright (c) 2009 Ramiro Polla
>
> Extra good karma for adding a short explanatory line to the top of the
> file.

Added.

>> #if ARCH_X86_64 || (ARCH_X86_32 && HAVE_7REGS)
>>
>>
>> #if ARCH_X86_64
>>
>> #else /* ARCH_X86_32 && HAVE_7REGS */
>>
>> #endif
>>
>> #endif /* ARCH_X86_64 || (ARCH_X86_32 && HAVE_7REGS) */
>
> This had me confused for a moment, please comment the #endif.

I used Loren's suggestion and added some comments to the endifs.

I also fixed the indentation of the function declaration and
simplified the constraints ifdef bit more. And also removed some
unnecessarily exported symbols and renamed them.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mlpdsp.c
Type: text/x-csrc
Size: 6409 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090515/3243cc80/attachment.c>



More information about the ffmpeg-devel mailing list