[FFmpeg-devel] [PATCH] libavfilter-soc: extend vf_scale.c to make it support colorspace details setting

Michael Niedermayer michaelni
Tue May 19 00:52:25 CEST 2009

On Mon, May 18, 2009 at 10:00:08PM +0200, Stefano Sabatini wrote:
> On date Monday 2009-05-18 03:03:00 +0200, Michael Niedermayer encoded:
> > On Sun, May 17, 2009 at 01:33:48PM +0200, Stefano Sabatini wrote:
> [...]
> > > The only alternative I see would be to redefine in the ScaleContext
> > > every single option of SWScaleContext, then map them to the
> > > corresponding SWScaleContext options when setting them, I avoided it
> > > since that looks more complicate.
> > > 
> > > Would that be acceptable?
> > 
> > no you seem to be missing the point
> > i want, none, ZERO not even a trace of any of these options in the filter
> > the filter should pass the stuff generically to swscale one way or another
> > This may not be achiveable and compromises might be needed but what your
> > patches do goes too far ...
> >
> > The various ways by which you dupllicate the AVOption list from swscale
> > is why iam so unhappy with this patch
> >
> > I dont know if it can be done without changes to swscale ...
> I have to confess that at this point I have no idea of what you
> mean... you want the scale filter to be configurable but
> "generically", which I don't know at all how to interpret.

heres a example:

generic code:
for(all input parameters given to us)
    give input parameter to sws

non generic code OTOH checks for "sws_flags" or contains tables of
names (if its a little less messy) and does all kinds of obscure
things with them

is it clear now?

> And I agree maybe more work should be done anyway on the swscale
> interface, in particulare the various lgb, lcb, cs, etc... values
> maybe should be set in the context with AVOptions.

> [...]
> > > Also pixdesc.{h,c} may be used in lsws to avoid code duplication, so
> > > maybe that could be moved (to lavu or maybe to a new lib
> > > libavpixels?).
> > 
> > iam not going to approve any new libs in relation to this patch.
> > libmpcodecs surely can use swscale without such stuff, libavfilter
> > should too
> Yes surely it can, but I believe using pixdesc.[ch] (and the
> colorspace stuff while at it) in libswscale may improve overall
> factorization of the code in FFmpeg.

this has nothing to do with this thread

> Also I don't like the idea of lavfi depending on lavc, after all
> decoding/encoding is quite a different thing with respect to
> filtering, and I can easily imagine an application needing to filter
> stuff without the need for encoding/decoding.

also off topic


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090519/f9f1e26a/attachment.pgp>

More information about the ffmpeg-devel mailing list