[FFmpeg-devel] [PATCH] EA TGQ video fixes
Wed May 20 22:07:16 CEST 2009
Reimar D?ffinger wrote:
> On Wed, May 20, 2009 at 06:07:53PM +0200, Vitor Sessak wrote:
>> Reimar D?ffinger wrote:
>>> On Fri, Apr 17, 2009 at 07:18:43AM -0700, Mike Melanson wrote:
>>>> Reimar D?ffinger wrote:
>>>>> I guess aliasing violations can be handled very differently.
>>>>> Anyway I committed one patch, it makes the PPC64/gcc4.1.2 results match
>>>>> with the test specification (well, I only compared the first and last
>>>>> few values I admit).
>>>>> Maybe you could just enable the test? I think we will be taking care of
>>>>> it in the near future if there are still issues left...
>>>> I am still seeing 6 unique sets of data. I don't want to enable a
>>>> bad/inconsistent test:
>>> Well, but that makes it really hard to find out which systems have
>>> issues and which kind of issues.
>>> If you don't want to enable them IMO you really need to add a way that
>>> they will at least be run anyway and the results are somehow possible to
>>> access, at least if you want it to be a help for bug fixing beyond only
>> Ping? I prefer not to leave the code buggy...
> Well, either
> 1) someone gives me access to a system where the tests do not match
> 2) someone with access to such a system debugs it
> 3) someone finds out what is special about Mike's systems that they
> give results all over the place while mine don't
> 4) I just blindly apply the patch and pray that someone somewhen checks
> if it fixed or broke something
> If you insist on 4) I'll do it, but my opinion should be obvious...
You are forgetting
5) fix an obvious bug and pray that it is the only one
6) wait forever for someone to report a bug in a reproducible way.
My point is just that 5) is better than 6). I agree that the ideal is
1), 2) or 3).
Anyway, again, does anyone get a different output for:
ffmpeg -idct simple -i
http://samples.mplayerhq.hu/game-formats/ea-tgq-uv/tgq/v27.tgq -an -t 10
-f framecrc - | md5sum
I get 2b84588602acda70269bd3e3aa1ce632
More information about the ffmpeg-devel