[FFmpeg-devel] [PATCH] libavfilter-soc: extend vf_scale.c to make it support colorspace details setting

Michael Niedermayer michaelni
Fri May 22 03:00:13 CEST 2009

On Fri, May 22, 2009 at 12:24:25AM +0200, Stefano Sabatini wrote:
> On date Wednesday 2009-05-20 04:02:12 +0200, Michael Niedermayer encoded:
> > there are 2 choices
> > 1. cleanup your code
> > 2. suggest changes to swscale and explain why they are needed to
> >    cleanup your code.
> > 
> > you dont explain what you exactly want to change to what and even less
> > so why this would reduce the mess in your patch
> >
> > Now if i guess what you mean, that is not related to why i rejected your
> > patch.
> > To oversimplify it a little
> > Your patch is rejected because instead of passing the letters from the
> > user to swscale you open them.
> > Now you seem to suggest to change the content of the letters, how
> > could that help cleaning your patch?
> Maybe I'm trying to get what you mean, in the direction of code
> cleanup, see attached.

I can no longer make sense of what you are trying to achive, i repeat over
and over again that we need a generic solution and you keep sending patches
failing the exactly same point:

> +static const AVOption scale_options[] = {
> +{ "sws_flags",       "scaler/cpu flags", OFFSET(sws_flags), FF_OPT_TYPE_FLAGS, SWS_BILINEAR, 0, UINT_MAX, 0, "sws_flags" },
> +{ "fast_bilinear",   "fast bilinear",                 0, FF_OPT_TYPE_CONST, SWS_FAST_BILINEAR,    INT_MIN, INT_MAX, 0, "sws_flags" },
> +{ "bilinear",        "bilinear",                      0, FF_OPT_TYPE_CONST, SWS_BILINEAR,         INT_MIN, INT_MAX, 0,

that is again a list of options, look
we have a user alice and we have sws and you are vf_scale ;)
alice gives you a bunch of zero terminated char* pairs and your only job
is to pass these strings to sws.

the moment you compare one of the strings against anything you already
have a problem.

Its like if i tell you to pass a name from alice to bob, at no point
in that do you need to look at the name.
You (vf_scale) cant know all names of all current and future people,
similarly vf_scale cannot know which options the swscale with which it is
linked contains.

As ive said a few times, we might need changes in swscale for this to work.

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090522/b3587b6a/attachment.pgp>

More information about the ffmpeg-devel mailing list