[FFmpeg-devel] [PATCH] use standard integer types in libavdevice/bktr.c

Måns Rullgård mans
Fri May 22 19:55:34 CEST 2009


Diego Biurrun <diego at biurrun.de> writes:

> On Fri, May 22, 2009 at 04:40:55PM +0100, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>> 
>> > libavdevice/bktr.c uses the BSD (?) variants like u_int64_t of standard
>> > integer types like uint64_t.  Here is a patch to change the file to the
>> > standard types that we use in other places, which I think is desirable.
>> >
>> > It's not compile-tested since I do not have access to a BSD system, but
>> > it should be trivial.
>> 
>> That file will only be used on BSD systems, so I don't see a problem.
>> The headers probably already use the BSD types, and mismatches might
>> result in compiler warnings (or worse).
>
> Even though uint8_t is already used?

I wouldn't touch code I can't compile, let alone test, unless it has
obvious bugs.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list