[FFmpeg-devel] [PATCH] Yet another stab at RGB48 support

Michael Niedermayer michaelni
Sat May 23 14:01:14 CEST 2009


On Sat, May 23, 2009 at 07:25:04AM +0300, Kostya wrote:
> On Sat, May 23, 2009 at 03:47:46AM +0200, Michael Niedermayer wrote:
> > On Fri, May 22, 2009 at 08:31:41AM +0300, Kostya wrote:
> [...]
> > > > these functions will be duplicated as swscale_template is included multiple
> > > > times
> > > 
> > > Theoretically someone can adapt MMX counterpart from rgb24to{Y,UV}
> > > Anyway, what do you suggest to avoid that? 
> > 
> > if its not building different variants then t doesnt belong in the template
> > 
> > 
> > > That's an issue with most of
> > > non-YUV functions there.
> > 
> > sws needs some cleanup ...
> 
> As I understand current situation, it works like that:
> 
> swscale.c uses different #defines for RENAME and HAVE_SOME_SIMD to
> include swscale_template.c
> 
> for x86 it may be included several times for MMX and 3DNOW
> (in practice it compiles only C version for me)
> 
> many of the functions there look like:
> static inline void RENAME(func)
> {
> #if HAVE_MMX
>  some asm
> #endif
>  C version that will be called nevertheless - usually for bitexact cases
> }
> 
> for almost all non-YUV converters (with the only exception being
> rgb24To{Y,UV} and bgr24To{Y,UV}) there's only C code
> 
> So it's up to you to decide how to deal with this.

I already said it, if there is just the C code, then the function doesnt
belong in the template.
Ive missed this issue until now so a few functions accumulated that should
not be there ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090523/d3d819e6/attachment.pgp>



More information about the ffmpeg-devel mailing list