[FFmpeg-devel] [PATCH] http Transfer-Encoding chunked

Michael Niedermayer michaelni
Sat May 23 19:39:55 CEST 2009


On Sat, May 23, 2009 at 11:55:41AM +0200, Peter Holik wrote:
> >> That was not working because http.c sends a HTTP/1.1 request and in the response
> >> i got a "Transfer-Encoding: chunked" Header - not known by http.c.
> >>
> >> The only drawback of my patch is, that the filesize is limited (i've taken 512 kByte)
> 
> >Just set filesize to -1 then, i.e. unlimited. Don't make up some
> >arbitrary number. It should just work.
> 
> Sorry, but this doesn't work for "image2"

image2 is not a http server. http.c is just connecting to a server and
reading data so i dont know what you mean by a reference to image2.


> 
> >For the last chunk, your patch reads:
> >0\r\n
> >which signals the last-chunk (empty). However, this should (if I
> >understand correctly) be followed by *another* \r\n before the next
> >HTTP header starts (in a stream if HTTP requests):
> >[.. end of old HTTP header ..]
> >Transfer-Encoding: chunked\r\n
> >\r\n
> >ae9\r\n
> ><data:0xae9>\r\n
> >0\r\n
> >\r\n
> >HTTP/1.1 200 OK
> >[.. rest of new HTTP header ..]
> 
> > Your patch doesn't skip this and thus only works for the first HTTP
> > data chunk (DAV servers use multiple in a session).
> 
> 
> That's true, i take only the chunks till i read a "0".

is your patch a implementation of chunked http transfers?
or is it a hack to somehow misuse image2 instead of using image2pipe?
if the later then iam not interrested i this any further.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090523/5d3d9061/attachment.pgp>



More information about the ffmpeg-devel mailing list