[FFmpeg-devel] [PATCH] Fix unaligned dsputil call in pngdec.c
Sun May 24 14:45:05 CEST 2009
Michael Niedermayer wrote:
> On Sat, May 23, 2009 at 06:01:41PM +0200, Vitor Sessak wrote:
>> Reimar D?ffinger wrote:
>>> On Sat, May 23, 2009 at 05:46:07PM +0200, Reimar D?ffinger wrote:
>>>> On Sat, May 23, 2009 at 05:32:10PM +0200, Vitor Sessak wrote:
>>>>> @@ -612,7 +613,7 @@
>>>>> ret = s->bytestream - s->bytestream_start;
>>>>> - av_freep(&s->crow_buf);
>>>>> + av_freep(&s->crow_buf - 15);
>>>> still won't do what you want at all, I recommend testing with valgrind.
>>>> Might be best to decrement crwo_buf first.
>> Indeed, 1000l.
>>> Of course after checking that it is !NULL first. I think that's going to
>>> become a mess, maybe split the variable, making crow_buf_base the
>>> malloced one, i.e.
>> Good idea, it is more readable like this.
>> pngdec.c | 11 ++++++++---
>> 1 file changed, 8 insertions(+), 3 deletions(-)
>> 225c886d77770d40affb5ee593690618a0aaeb85 png4.diff
> iam fine with it assuming reimar & mans have no further comments
More information about the ffmpeg-devel