[FFmpeg-devel] [PATCH] Fix compilation when MMX is disabled

[Jai Menon]

On Mon, May 25, 2009 at 5:16 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Mon, May 25, 2009 at 05:03:35PM +0000, Jai Menon wrote:
>> On Mon, May 25, 2009 at 5:01 PM, Diego Biurrun <diego at biurrun.de> wrote:
>> > On Mon, May 25, 2009 at 04:26:06PM +0000, Jai Menon wrote:
>> >> On Mon, May 25, 2009 at 4:00 PM, Reimar D?ffinger
>> >> <Reimar.Doeffinger at gmx.de> wrote:
>> >> > On Mon, May 25, 2009 at 03:12:50PM +0000, Jai Menon wrote:
>> >> >> As in subject.
>> >> >
>> >> > Looks completely wrong, mlpdsp asm does not use MMX.
>> >>
>> >> I know it doesn't use MMX, but couldn't find any other way to do it. I
>> >> was hoping somebody would suggest the correct way. Should there be a
>> >> X86-OBJS ?
>> >
>> > OBJS-$(ARCH_X86), similar to what we have for all other ARCHs.
>>
>> And how should the CONFIG_MLP_DECODER and CONFIG_TRUEHD_DECODER flags
>> be checked?
>
> With the same trick that we use for e.g. MMX-OBJS and OBJS-$(HAVE_MMX).

Is something like :

X86-OBJS-$(CONFIG_MLP_DECODER)               += x86/mlpdsp.o
X86-OBJS-$(CONFIG_TRUEHD_DECODER)         += x86/mlpdsp.o

what you intended? It doesn't  works though.

Anyway, If you or anyone has a knows how to, please fix this. Its sad
to see that the build fails.

> Diego

-- 
Regards,

Jai