[FFmpeg-devel] [PATCH] seperate parser from codec selection
Tue May 26 13:34:05 CEST 2009
On Tue, May 26, 2009 at 12:23:55PM +0200, Michael Niedermayer wrote:
> On Tue, May 26, 2009 at 06:56:14PM +1200, Paul Kendall wrote:
> > On Tuesday 26 May 2009 02:02:09 pm Michael Niedermayer wrote:
> > > On Sun, May 17, 2009 at 03:25:22PM +1200, Paul Kendall wrote:
> > > > This patch allows an AVStream to specify a parser_id separately to the
> > > > codec_id. This will be useful for streams such as DVB-T which has AAC
> > > > audio which may be contained in an LATM multiplexed stream.
> > > >
> > > > The patch will fall-back to using the codec_id for parser selection if
> > > > the parser_id is set to CODEC_ID_NONE, which is the default.
> > >
> > > I do not like having 2 codec ids.
> > >
> > > [...]
> > >
> > > > enum CodecID codec_id; /* see CODEC_ID_xxx */
> > > > + enum CodecID parser_id; /* see CODEC_ID_xxx */
> > >
> > > even less so without any documentation
> > >
> > > [...]
> > Micheal, would it be preferable to make a new enum for parsers such as
> > PARSER_ID_xxx?
> fields are not just random numbers to be hacked as needed for each issue
> without thought about the semantical effect.
> codec_id represents the format of the bitstream
> Either it is the same for the various AAC variants, in which case all code
> claiming to support CODEC_ID_AAC should also support all AAC variants (as they
> are implicated by the codec_id)
> there are 2 AAC codec_ids in which case there are at least 2 options
> A. find a way to chain demuers cleanly, each would have its own codec_id
> clearly seperated
> B. extend the API of bitstream filters so they can change codec_id and
> add have a pre and post automatic bitstream filtering codec_id, this
> requires review and adjustment of all code using codec_id
> There maybe other options, but CODEC_ID_AAC cannot mean different things
> depending on where its used that would be a too obscure design, that noone
> would understand.
in the long run, being able to chain demuxers would surely be the nicest and
most powerfull, and it might against my expectation not really harder than
the other solutions as we keep running into issues with them ...
To chain demuxer we would need the following:
1. a generic combining demuxer, that being just a simple demuxer that
passes its read_packet/read_header to its parent demuxer(s)
The purpose of this one is just to turn the AVFormatContexts and AVStreams
of more than 1 demuxer into a single AVFormatContext with its AVStreams
so the user can use several demuxers through the single demuxer API.
2. We need a LATM demuxer (which should be very trivial) its input just
being LATM and its output just being a single [or in the future >1]
no LATM AAC AVStream
3. We need a URLProtocol or ByteIOContext that takes the packets a demuxer
outputs as its input.
4. The whole chain could then be setup by the core simply by checking if
codec_id of any stream is one that needs a demuxer.
_________ ________ _________
| | -stream0->| |-----------------------------stream0-->| |-stream0->
| | | | _____________ _______ | |
| | | | |Packet to | |LATM |-stream1a->| |-stream1->
| MPEG-PS | -stream1->| Packet |->|ByteIOContext|->|Demuxer| |Combining|
| Demuxer | | Buffer | |_____________| |_______|-stream1b->| Demuxer |-stream2->
| | | | | |
Comments, especially from members of other project that do support chaining
demuxers is welcome!
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel