[FFmpeg-devel] [RFC][PATCH] return packets for known codecs earlier when codec probing is done

Baptiste Coudurier baptiste.coudurier
Wed May 27 09:54:27 CEST 2009


Hi Michael,

Michael Niedermayer wrote:
> [...]
> 
>> @@ -537,10 +537,18 @@ int av_read_packet(AVFormatContext *s, AVPacket *p
>>  
>>          av_init_packet(pkt);
>>          ret= s->iformat->read_packet(s, pkt);
>> -        if (ret < 0)
>> -            return ret;
>> +        if (ret < 0) {
>> +            if (!pktl)
>> +                return ret;
>> +            for (i = 0; i < s->nb_streams; i++)
>> +                if (s->streams[i]->codec->codec_id == CODEC_ID_PROBE)
>> +                    s->streams[i]->codec->codec_id = CODEC_ID_NONE;
>> +            continue;
>> +        }
> 
> i dont like this
> 

Well, we have a problem if probe_packets is not 0 when eof is reached.
Do you see another way to avoid this ?

Patch updated.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: probe_pktl5.patch
Type: text/x-diff
Size: 3018 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090527/8835eb03/attachment.patch>



More information about the ffmpeg-devel mailing list