[FFmpeg-devel] [PATCH] Fix 64 bit truncation in asfdec.c

David DeHaven dave
Thu May 28 17:24:10 CEST 2009


>> -static int get_value(ByteIOContext *pb, int type){
>> +static uint64_t get_value(ByteIOContext *pb, int type){
>
> why do you change it from signed to unsigned?


It's only used to read boolean (where sign doesn't matter since it's  
one or zero), WORD, DWORD or QWORD which AFAIK are all unsigned  
values. That, and it's only called once in the file and it's cast to  
uint64_t.

-DrD-




More information about the ffmpeg-devel mailing list