[FFmpeg-devel] [PATCH] extract bit rate calculation into separate function
Fri Nov 13 08:59:16 CET 2009
On 12.11.2009, at 19:29, Michael Niedermayer wrote:
> On Thu, Nov 12, 2009 at 09:13:58AM +0100, Robert Kr?ger wrote:
>> On 12.11.2009, at 01:42, Stefano Sabatini wrote:
>>> On date Wednesday 2009-11-11 12:41:33 +0100, Robert Kr?ger encoded:
>> hmm, I tried not to change the behaviour of the code I extracted as
>> I only
>> wanted to refactor and what you suggest would change the behaviour
>> CODEC_TYPE_UNKNOWN , CODEC_TYPE_ATTACHMENT and CODEC_TYPE_NB as it
>> no longer return 0 but return ctx->bit_rate. If that makes sense, I
>> judge. I'll change it accordingly, if you say it does.
> you could send 2 pathes
> first to move the code, second to simplify it
OK, then consider the first one submitted with my most recent email.
More information about the ffmpeg-devel