[FFmpeg-devel] [PATCH] AVHWAccel infrastructure v2 (take 3)

Gwenole Beauchesne gbeauchesne
Fri Nov 13 16:50:11 CET 2009


On Mon, 9 Nov 2009, Michael Niedermayer wrote:

> [...]
>> @@ -2526,6 +2527,14 @@ typedef struct AVCodecContext {
>>       * - decoding: Set by libavcodec
>>       */
>>       enum AVChromaLocation chroma_sample_location;
>> +
>> +    /**
>> +     * Hardware accelerator configuration attributes.
>> +     * The array is terminated by HWACCEL_ATTR_NONE.
>> +     * - encoding: unused
>> +     * - decoding: Set by user
>> +     */
>> +    const uintptr_t *hwaccel_attrs;
>>  } AVCodecContext;
>>
>>  /**
>
> uintptr_t is an optional type in C
> and i really have a bad feeling about using it in public API, i bet this
> will break several compilers
>
> and this way of passing information/attributes is very odd and there is
> no support in AVOptions to deal with that
> so i really think a int someflags would be better

Do you mean I should use AVOptions directly + add an FF_OPT_TYPE_POINTER? 
The problem is I don't see any codec using av_get_*() so I don't think 
that was what you meant or is there another API to access AVOptions?

Thanks,
Gwenole.



More information about the ffmpeg-devel mailing list