[FFmpeg-devel] [PATCH] Merge ALS data tables with decoder

Måns Rullgård mans
Sat Nov 14 12:59:14 CET 2009


Michael Niedermayer <michaelni at gmx.at> writes:

> On Sat, Nov 14, 2009 at 07:45:09AM +0100, Thilo Borgmann wrote:
>> Hi,
>> 
>> as suggested by Diego, this patch merges the data tables with the
>> decoder source to reduce unnecessary code complication.
>
> I see no harm done by the seperate tables, it also keeps files
> smaller, that said i dont object to moving them in the C file i just
> think nothing is gained by that

The tables should either be in the single file that needs them or in
another C file with declarations in a header file.  A header file
should never produce any code or data by itself (inline functions
exempt).

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list