[FFmpeg-devel] [PATCH] Merge ALS data tables with decoder

Thilo Borgmann thilo.borgmann
Sat Nov 14 13:37:38 CET 2009

Diego Biurrun schrieb:
> On Sat, Nov 14, 2009 at 01:09:13PM +0100, Thilo Borgmann wrote:
>> M?ns Rullg?rd schrieb:
>>> Michael Niedermayer <michaelni at gmx.at> writes:
>>>> On Sat, Nov 14, 2009 at 07:45:09AM +0100, Thilo Borgmann wrote:
>>>>> as suggested by Diego, this patch merges the data tables with the
>>>>> decoder source to reduce unnecessary code complication.
>>>> I see no harm done by the seperate tables, it also keeps files
>>>> smaller, that said i dont object to moving them in the C file i just
>>>> think nothing is gained by that
>>> The tables should either be in the single file that needs them or in
>>> another C file with declarations in a header file.  A header file
>>> should never produce any code or data by itself (inline functions
>>> exempt).
>> I'm really sorry, it seems like I have to be more patient... ok, I'm
>> fine with moving them out of alsdec.c into another .c file again if that
>> will be the consensus finally.
> Why?  Mans offered two alternatives, one of which you now implemented.
> He was just saying that the original one was bad.

Indeed, needed to read "single file" twice... thanks!


More information about the ffmpeg-devel mailing list