[FFmpeg-devel] [PATCH] instead of crashing print warning for MJPEG flipped + CODEC_FLAG_EMU_EDGE

Michael Niedermayer michaelni
Tue Nov 17 23:50:58 CET 2009


On Tue, Nov 17, 2009 at 03:35:28PM +0100, Reimar D?ffinger wrote:
> Hello,
> completely failing would be another option, but simply crashing or even
> just asserting due to missing padding if an application uses
> CODEC_FLAG_EMU_EDGE IMO is not acceptable.

Fixing the case seems to make more sense, until then your patch is ok of
course
using a temp buffer or just skiping the last row seem better ...


> Possibly an extra flag in the context to print this warning only once
> would make sense (or would a static variable be ok as well?).

seems overkill for this workaround

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091117/13e32f0c/attachment.pgp>



More information about the ffmpeg-devel mailing list