[FFmpeg-devel] [PATCH] Fix possible SIGFPEs with bad mov timings. Based on chromium patch 35_mov_bad_timings.patch

Michael Niedermayer michaelni
Fri Nov 20 19:23:33 CET 2009


On Thu, Nov 19, 2009 at 11:34:30AM -0800, Baptiste Coudurier wrote:
> On 11/19/2009 10:52 AM, Michael Niedermayer wrote:
>> On Thu, Nov 19, 2009 at 12:12:30PM -0500, Ronald S. Bultje wrote:
>>> Hi,
>>>
>>> On Thu, Nov 19, 2009 at 1:45 AM, Baptiste Coudurier
>>> <baptiste.coudurier at gmail.com>  wrote:
>>>> I don't like the<  0 check, but I guess we don't have much choice here.
>>>
>>> Er...
>>>
>>> A) AVURational (bikeshed!!!!111)
>>
>> no i wont buy you a second bike because you dont like the color of the one
>> you alraedy have
>>
>>
>>> B) uint32_t num = READ_BE32(..), den = READ_BE32(..);
>>>      if (num&  0x80000000 || den&  0x80000000) { den>>= 1; num>>= 1 }
>>
>> dont do this period
>> we have av_reduce() that does this properly, and av_set_pts_info() already
>> uses it.
>
> num is 1 for mov.

:(

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091120/978e78f2/attachment.pgp>



More information about the ffmpeg-devel mailing list