[FFmpeg-devel] [RFC] Request for pixdesc API review
Sat Nov 21 17:00:58 CET 2009
On date Monday 2009-11-16 00:43:02 +0100, Stefano Sabatini encoded:
> On date Sunday 2009-11-08 18:35:43 +0100, Stefano Sabatini encoded:
> * In order to prove that the API is expressive enough, I rewrote
> ff_fill_linesize() and ff_fill_pointer() in imgconvert.c to make use
> of pixdescs, the experiment resulted in code more generic and
> functionally equivalent to the old one (it requires some patches I
> posted today), sample patch attached.
Some more consideration about expressivity.
PixFmtInfo contains the color_type value which can assume these
we came to the conclusion that colorspace information don't belong to
pixdesc, so some of these informations cannot be put in the pixdesc,
we could still add some macros in imgconvert.c and use them and still
be able to dump PixFmtInfo, would be this acceptable?
Similarly for the PixFmtInfo.is_alpha field we could either use a
PIX_FMT_ALPHA flag (not sure this is a good idea, afterall this may be
considered as a colorspace info) or use some macro.
Comments are welcome.
FFmpeg = Fast Fundamental Murdering Problematic Earthshaking God
More information about the ffmpeg-devel