[FFmpeg-devel] [PATCH] Fix linesize computation for NV formats

[Michael Niedermayer]

On Fri, Nov 20, 2009 at 09:56:32AM -0200, Ramiro Polla wrote:
> On Thu, Nov 19, 2009 at 10:54 PM, Ramiro Polla <ramiro.polla at gmail.com> wrote:
> > On Thu, Nov 19, 2009 at 10:38 PM, Stefano Sabatini
> > <stefano.sabatini-lala at poste.it> wrote:
> >> On date Thursday 2009-11-19 17:51:30 +0100, Michael Niedermayer encoded:
> >>> On Thu, Nov 19, 2009 at 01:37:03AM +0100, Stefano Sabatini wrote:
> >> [...]
> >>> > So basically all the code affected by the change is indeed code which
> >>> > is never used, my patch simply makes the linesize params semantics for
> >>> > NV formats consistent with that of all the other formats (thus
> >>> > simplifying the code if we choose to use pixdesc for ff_fill_XXX).
> >>>
> >>> if no code uses NV12 it should be removed (i dont belive this though)
> >>> if any code uses NV12 your patch will break it.
> >>
> >> ffmpeg doesn't support NV12 as input, but can convert to NV12 /
> >> NV21. So we can create a stream with pix_fmt nv12 but there is no mean
> >> to visually test it (e.g. with ffplay) or convert it back to a stream
> >> which is playable by ffmpeg, but maybe someone can suggest some way to
> >> display such a format e.g. with mplayer or vlc.
> >>
> >> Also I wonder how hard would be to add it as an input format in lsws.
> >
> > I have a device with a hardware decoder to nv12 that also displays in
> > nv12 at work. I might take a look tomorrow if I manage to find some
> > time...
> 
> One more change was needed to get raw nv12 output properly. With
> attached patch I can
> ./ffmpeg_g -i input.avi -s 1280x720 -pix_fmt nv12 -f rawvideo -y output.nv12
> and then feed output.nv12 to the display frame by frame.
> 
> I haven't worked on nv12 support as input to swscale yet. I'll do it
> either this afternoon or in two weeks =)
> 
> Ramiro Polla

>  imgconvert.c |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 23a08f3e04d937fa4f0cd84645b99ad418a237e2  nv12.diff

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091124/7b980b35/attachment.pgp>