[FFmpeg-devel] [PATCH] Add writing of vorbis comments to flac files

James Darnley james.darnley
Tue Oct 20 17:10:51 CEST 2009


Hello,
I have attached a patch which adds the creation of vorbis comments
from AVMetadata and the writing of this as a
METADATA_BLOCK_VORBIS_COMMENT in a flac file.

Could someone please double check libavformat/makefile and the
#includes on the files to eliminate any redundant options or to add
any I have missed.

I do have a question or two.
Is it possible to determine the length of the audio from the
AVFormatContext struct?  I tried a couple of "duration" values but
they always seemed to be 0.
If that is not possible, is there a value in AVFormatContext which
could be interpreted as a header padding value, a value which might
request N bytes of padding?
I ask because there is also the possibility of writing a
METADATA_BLOCK_PADDING to allow extra metadata or possibly a seek
table to be added later without the need to rewrite the whole file.

Thanks for any comments.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg_flac-tags_10_r20332M.diff
Type: application/octet-stream
Size: 9962 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091020/268c4d41/attachment.obj>



More information about the ffmpeg-devel mailing list