[FFmpeg-devel] [PATCH] Add crop filter

[Michael Niedermayer]

On Wed, Oct 21, 2009 at 12:51:42AM +0200, Stefano Sabatini wrote:
> On date Tuesday 2009-10-20 01:14:20 +0200, Michael Niedermayer encoded:
> > On Mon, Oct 19, 2009 at 11:50:08PM +0200, Stefano Sabatini wrote:
> > > On date Friday 2009-10-16 12:49:33 +0200, Michael Niedermayer encoded:
> > > > On Fri, Oct 16, 2009 at 12:34:07AM +0200, Stefano Sabatini wrote:
> > [...]
> > > > > +        round_hsub = crop->hsub;
> > > > > +        round_vsub = crop->vsub;
> > > > > +    }
> > > > > +
> > > > > +    crop->x &= ~((1 << round_hsub) - 1);
> > > > > +    crop->y &= ~((1 << round_vsub) - 1);
> > > > 
> > > > > +    crop->w &= ~((1 << round_hsub) - 1);
> > > > > +    crop->h &= ~((1 << round_vsub) - 1);
> > > > 
> > > > i dont think these are needed
> > > 
> > > How so?
> > 
> > ffmpeg should support all videos, even ones with odd with or height,
> > they arent common but they do exist out there.
> 
> Patch updated with other minor fixes.

[...]
> +static int query_formats(AVFilterContext *ctx)
> +{
> +    enum PixelFormat pix_fmts[] = {

static const

looks ok except that given it has been tested extensively
for example no slowdown if multiple crop filters are added in a row in
any filter chain

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

> ... defining _GNU_SOURCE...
For the love of all that is holy, and some that is not, don't do that.
-- Luca & Mans
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091021/a7cebd00/attachment.pgp>