[FFmpeg-devel] [PATCH] support for hardcoded mpegaudiodec tables

[Reimar Döffinger]

On Wed, Oct 21, 2009 at 07:44:57PM +0200, Michael Niedermayer wrote:
> On Wed, Oct 21, 2009 at 05:50:03PM +0200, Reimar D?ffinger wrote:
> > what is an acceptable way to avoid that to you?
> 
> > Putting that duplicated part into a header?
> > Or a separate .c file?
> 
> yes both are possible, either way it should be done for all (non small)
> hardcoded tables and the files should have consistent names like
> mpegaudiodec_tblgen.c or so
> all these files should be listed at Makefile level and Makefile
> magic should then either link them into libav* or link them to a
> table printer, print the tables, compile them and link them
> ... or something like that ...

Sorry, but I just can't parse it. In addition, it makes no sense to me,
if it's supposed to be switched by linking using a .h file is not possible.
Furthermore if those tables are supposed to be compiled and linked separately
that means it will be impossible to hardcode static tables, and it also
means that renaming them to ff_ is a must to hardcode them.
Also "either link them into libav* or link them to a table printer" is not
possible either since those two may be compiled for different architectures,
and worse we can not use config.h for the host-compiled stuff.
I attached a maybe better patch, but I'll surely be flamed for that as
well because it breaks "make checkheaders" but I don't see a way to avoid
that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpatables.diff
Type: text/x-diff
Size: 7607 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091021/80247905/attachment.diff>