[FFmpeg-devel] [PATCH] libspeex Speex encoding

[Diego Biurrun]

On Mon, Oct 26, 2009 at 09:37:21AM +0000, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Sun, Oct 25, 2009 at 09:04:45AM -0400, Justin Ruggles wrote:
> >> 
> >> --- a/libavcodec/avcodec.h
> >> +++ b/libavcodec/avcodec.h
> >> @@ -31,7 +31,7 @@
> >>  
> >>  #define LIBAVCODEC_VERSION_MAJOR 52
> >>  #define LIBAVCODEC_VERSION_MINOR 37
> >> -#define LIBAVCODEC_VERSION_MICRO  1
> >> +#define LIBAVCODEC_VERSION_MICRO  2
> >
> > What is it with micro bumps all of a sudden?  You need to bump minor.
> 
> What exactly are the rules?

The ones outlined in our development policy:
http://www.ffmpeg.org/developer.html

1.4 Development Policy
16. Remember to check if you need to bump versions for the specific libav
    parts (libavutil, libavcodec, libavformat) you are changing. You need
    to change the version integer. Incrementing the first component means
    no backward compatibility to previous versions (e.g. removal of a
    function from the public API). Incrementing the second component
    means backward compatible change (e.g. addition of a function to the
    public API or extension of an existing data structure). Incrementing
    the third component means a noteworthy binary compatible change (e.g.
    encoder bug fix that matters for the decoder).

1.6 New codecs or formats checklist
3. Did you bump the minor version number in `avcodec.h' or `avformat.h'?


For each new format the minor of the corresponding lib has to be bumped.

Vitor seems to have managed to bend the rules in people's head by
setting just one bad example...

Diego