[FFmpeg-devel] [PATCH] remove pnm code cruft

[Diego Biurrun]

On Tue, Oct 27, 2009 at 02:49:02PM +0100, Michael Niedermayer wrote:
> On Tue, Oct 27, 2009 at 01:58:53PM +0100, Diego Biurrun wrote:
> > On Tue, Oct 27, 2009 at 01:49:42PM +0100, Michael Niedermayer wrote:
> > > On Tue, Oct 27, 2009 at 10:44:12AM +0000, M?ns Rullg?rd wrote:
> > > > Michael Niedermayer <michaelni at gmx.at> writes:
> > > > 
> > > > > On Tue, Oct 27, 2009 at 11:06:03AM +0100, Diego Biurrun wrote:
> > > > >> This removes some cruft from pnmenc.c.  I intend to split the file
> > > > >> afterwards, so removing cruft seems like a good first step.
> > > > >
> > > > > instead of removing the probe code, the code should be used
> > > > 
> > > > That code is a remnant from when this file was in lavf.
> > > 
> > > yes
> > > 
> > > >  It should be deleted.
> > > 
> > > no
> > > Id like to have functioning image2 probing.
> > 
> > > This code should be exported from the decoder (AVCodec.probe maybe)
> > > and then img2.c image_probe() should call that for all image codecs
> > > for probing instead of pure filename extension based probing.
> > 
> > Do it.  If you haven't done it by next week, I will just delete the
> > non-compiling cruft, since it will never be used nor repaired.
> 
> Have you not considered that i could maybe implement it after next week
> after reading your prediction? ;)

The possibility has crossed my mind, yes :)

> Seriously, ill look at implementing this one if that makes you happy
> it should be quite trivial

Fine.  You are competent enough to resurrect the code from Subversion.
In the meantime I will remove it and proceed to clean up the pnm code.
I have some build issues to fix with --disable-optimizations and
--disable-encoders.

Diego