[FFmpeg-devel] [PATCH] Add slicify filter

[Stefano Sabatini]

On date Friday 2009-10-30 19:30:35 +0100, Diego Biurrun encoded:
> On Fri, Oct 30, 2009 at 12:45:57PM +0100, Stefano Sabatini wrote:
> > 
> > --- ffmpeg.orig/doc/libavfilter.texi	2009-10-30 12:30:34.000000000 +0100
> > +++ ffmpeg/doc/libavfilter.texi	2009-10-30 12:32:23.000000000 +0100
> > @@ -174,6 +174,20 @@
> >  
> >  The default value of ``width'' and ``height'' is 0.
> >  
> > + at section slicify
> > +
> > +Pass the input video to next filter as multiple slices.
> > +
> > + at example
> > +./ffmpeg -i in.avi -vfilters "slicify=32" out.avi
> > + at end example
> > +
> > +The filter accepts as parameter the slice height (16 if not
> > +specified).
> 
> The filter accepts the slice height as parameter

Fixed.
 
> > +Adding this in the beginning of filter chains should make filtering
> > +faster due to the better use of the memory cache.
> 
> due to better use

Fixed.
 
> Your descriptions are improving.  Keep going.

To be honest, your fixes regarded the few parts I edited from the
original description :-(...

> > --- ffmpeg.orig/libavfilter/allfilters.c	2009-10-30 12:29:59.000000000 +0100
> > +++ ffmpeg/libavfilter/allfilters.c	2009-10-30 12:32:56.000000000 +0100
> > @@ -39,5 +39,6 @@
> >      REGISTER_FILTER (SCALE,scale,vf);
> > +    REGISTER_FILTER (SLICIFY,slicify,vf);
> >      REGISTER_FILTER (VFLIP,vflip,vf);
> 
> I insist that there should be spaces after the commas here.

I'll do that (globally) in a separate patch.
 
> > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > +++ ffmpeg/libavfilter/vf_slicify.c	2009-10-30 12:45:40.000000000 +0100
> > @@ -0,0 +1,102 @@
> > +
> > +/**
> > + * @file libavfilter/vf_slicify.c
> > + * slicing video filter
> 
> I'm unhappy with "slicing" but I'm at a loss to provide you a better
> alternative... :-/

video slicing video filter -> video slicing [video] filter ->
video slicing filter.

The second "video" can be omitted, since it's clear from the context,
this is what suggested by Ben and also like in the original version by
Bobby.

While at it I also changed the description of the filter to the
original by Bobby:
"Pass on input video to next video filter as multiple slices."

I also added a get_video_buffer() callback definition, which is not
currently required, but it could be soon.

Regards.
-- 
FFmpeg = Furious Friendly Mystic Proud Elitist Generator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-slicify-filter.patch
Type: text/x-diff
Size: 5526 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091031/ca2a7611/attachment.patch>