[FFmpeg-devel] [PATCH]Do not allow 0 threads

Jason Garrett-Glaser darkshikari
Thu Sep 3 10:48:20 CEST 2009

2009/9/3 M?ns Rullg?rd <mans at mansr.com>:
> Jason Garrett-Glaser <darkshikari at gmail.com> writes:
>> On Wed, Sep 2, 2009 at 4:37 PM, Baptiste
>> Coudurier<baptiste.coudurier at gmail.com> wrote:
>>> Hi Carl Eugen,
>>> On 09/02/2009 04:12 PM, Carl Eugen Hoyos wrote:
>>>> Hi!
>>>> Attached patch should fix issue 1333.
>>> Isn't 0 threads, "auto" with libx264 ?
>> Yes, though only because 0 happens to be defined as X264_THREADS_AUTO
>> in x264.h. ?Proper fix would be to actually parse "auto" on the
>> commandline correctly, but if that can't be done, it's at least better
>> to leave it as it is so that "auto" can even be used...
> Another option is to document 0 as meaning auto.

Or do both; document 0 as meaning auto in the API *and* allow "auto"
as a commandline option.

Of course, one has to deal with all the codecs for which "auto" is not
implemented (i.e. everything but x264...)

Dark Shikari

More information about the ffmpeg-devel mailing list