[FFmpeg-devel] [PATCH] Use all 32 bits of the timestamp when calculating flv duration

Martin Storsjö martin
Thu Sep 3 15:48:44 CEST 2009

On Thu, 3 Sep 2009, Michael Niedermayer wrote:

> On Thu, Sep 03, 2009 at 04:18:50PM +0300, Martin Storsj? wrote:
>> $subj. At the moment, the duration is mainly set from the metadata packet,
>> but if that isn't available, the fallback by checking the timestamp of the
>> last packet really should read all 32 bits of the timestamp, not just the
>> low 24 bits as currently.
> ok if its confirmed that this does fix a bug

Yes, I tested it that it fixes a bug, otherwise the duration is wrong for 
all files over 4,6 hours.

Attached a version that adds proper spacing around the equals sign, so 
that we clean up whitespace for lines that we're touching anyway.

> also the code could maybe be factored out, we have that 24+8 reading in there
> twice

That might be a good idea...

// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: flv-duration.patch
Type: text/x-diff
Size: 646 bytes
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090903/d3059808/attachment.patch>

More information about the ffmpeg-devel mailing list