[FFmpeg-devel] [RFC] make sure $TMPE is executable

Reimar Döffinger Reimar.Doeffinger
Thu Sep 10 14:36:05 CEST 2009


Hello,
it seems that "GNU gold (GNU Binutils 2.19.1) 1.7" has a strange bug
where if the output file already exists and is not executable, it
will stay not executable.
This causes all check_exec calls to fail.
Now since it _might_ be intended behaviour and since I am too lazy to
report elsewhere, I wanted to ask if we should fix this in our
configure, e.g. like this:
Index: configure
===================================================================
--- configure   (revision 19808)
+++ configure   (working copy)
@@ -697,7 +697,7 @@
 }
 
 check_exec(){
-    check_ld "$@" && { enabled cross_compile || $TMPE >> $logfile 2>&1; }
+    check_ld "$@" && { enabled cross_compile || chmod +x $TMPE && $TMPE >> $logfile 2>&1; }
 }
 
 check_exec_crash(){

Or like this:
Index: configure
===================================================================
--- configure   (revision 19808)
+++ configure   (working copy)
@@ -1489,6 +1489,7 @@
 
 tmpfile TMPC  .c
 tmpfile TMPE  $EXESUF
+chmod +x $TMPE
 tmpfile TMPH  .h
 tmpfile TMPO  .o
 tmpfile TMPS  .S




More information about the ffmpeg-devel mailing list