[FFmpeg-devel] [PATCH] support for UTF-16 encoding in id3v2 tags

Anton Khirnov wyskas
Fri Sep 11 10:33:37 CEST 2009


On Thu, Sep 10, 2009 at 01:07:17PM +0200, Michael Niedermayer wrote:
> 
> can be set before the switch() as default
> 
> 
fixed
> 
> GET_16BIT not GET_BYTE
> 
fixed
> 
> missing error checking
> 
> unsigned int hi= val - 0xD800;
> if(hi < 0x800) {
>     val= get(s->pb) - 0xDC00;
>     if(val > 0x3FFU || hi > 0x3FFU){
>         ERROR
>     }
>     val+= (hi<<10) + 0x1000;
> }
> 
fixed


On Thu, Sep 10, 2009 at 01:58:57PM +0200, Reimar D?ffinger wrote:
> 
> Of course it should be
> GET_16BIT, not get(s->pb).
> _______________________________________________
oops :) you're right of course, fixed.

Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-id3v2-add-support-for-UTF-16-encoding.patch
Type: text/x-diff
Size: 3335 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090911/e30af065/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090911/e30af065/attachment.pgp>



More information about the ffmpeg-devel mailing list