[FFmpeg-devel] [PATCH] remove unneeded tags in vorbiscomment_metadata_conv

Justin Ruggles justin.ruggles
Sat Sep 12 17:24:03 CEST 2009

Aurelien Jacobs wrote:

> On Thu, Sep 10, 2009 at 09:07:58PM -0400, Justin Ruggles wrote:
>> Hi,
>> Some of the entries in the vorbiscomment conversion table are unneeded
>> because metadata key comparisons are case insensitive.
> IIRC those entries will be useful if this table is ever used for muxing
> vorbiscomment (so that vorbis files are written with the correct vorbis
> caseing).
> If you are sure this table won't ever get used for muxing, or if you
> provide other way of uppercasing keys while muxing, fell free
> to remove those entries.

I think the table will be useful for muxing, but I also think the
vorbiscomment writer will always need to convert all keys, whether
converted or from the user, to uppercase in order to be compliant with
the spec.


More information about the ffmpeg-devel mailing list