[FFmpeg-devel] [PATCH] add small sizes to ff_sine_windows[] array

Vitor Sessak vitor1001
Mon Sep 14 18:34:41 CEST 2009

Reimar D?ffinger wrote:
> On Mon, Sep 14, 2009 at 06:09:46PM +0200, Vitor Sessak wrote:
>> Hi,
>> This should fix issue 1384 with TwinVQ decoder. I could add just a 
>> couple of sizes, but I think that adding all the seven are worth it to 
>> completely avoid this kind of error in the future. It also IMHO improves 
>> of clarity of the resulting code, for example:
>>> -    ff_sine_window_init(ff_sine_windows[av_log2(mtab->size) - 7], mtab->size);
>>> +    ff_sine_window_init(ff_sine_windows[av_log2(mtab->size)], mtab->size);
> Personally, I'd be in favour of expanding ff_sine_windows to have space
> for all, but set the unused parts to NULL.

Fine by me. New patch attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sine_win2.diff
Type: text/x-diff
Size: 4049 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090914/e04d3559/attachment.diff>

More information about the ffmpeg-devel mailing list