[FFmpeg-devel] [PATCH] probetest.c
Mon Sep 14 19:30:29 CEST 2009
On Mon, Sep 14, 2009 at 07:07:40PM +0200, Michael Niedermayer wrote:
> On Mon, Sep 14, 2009 at 05:56:39PM +0200, Reimar D?ffinger wrote:
> > On Mon, Sep 14, 2009 at 05:19:03PM +0200, Michael Niedermayer wrote:
> > > Failure of mm probing code with score=50 type=0 p=FC0 size=128
> > Hm, the libavformat/mm.c check looks fairly ok to me as it is, is this
> > just bad luck or have I missed something?
> #define MM_TYPE_HEADER 0x0
> #define MM_HEADER_LEN_V 0x16 /* video only */
> so it really just tests for 6 bytes being 0 except one bit being 1
> that _is_ weak IMHO
Hm. Well, in reality probably yes. But against truly random (or
generally any well-compressed) data it should work good enough...
It's not only one bit, it's 4 or 2 bits 1 (not that it matters much).
More information about the ffmpeg-devel