[FFmpeg-devel] [PATCH] Stricter TMV probe

Ronald S. Bultje rsbultje
Mon Sep 14 22:05:34 CEST 2009


On Mon, Sep 14, 2009 at 3:51 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> Not really related to this specific patch, just because every probe
> function checks sample_rate:
> A lot of demuxers (including that one) do not validate it in
> read_header, ending up with 1/0 as time base. That really is not ok (and
> as said, I have the impression a lot of demuxers do that).

I think just checking for != 0 isn't enough. A samplerate of 1 might
be valid, but isn't. I mean, it wouldn't produce anything audible. A
min. samplerate of e.g. 1000 seems appropriate, and for many gaming
formats, a max of e.g. 192000 might also be useful.

Similar restrictions might apply to other properties.


More information about the ffmpeg-devel mailing list