[FFmpeg-devel] [PATCH] probetest.c

Reimar Döffinger Reimar.Doeffinger
Tue Sep 15 11:04:05 CEST 2009

On Tue, Sep 15, 2009 at 10:46:04AM +0200, Michael Niedermayer wrote:
> On Tue, Sep 15, 2009 at 09:23:13AM +0200, Reimar D?ffinger wrote:
> > Maybe should add some options to limit its agressiveness, because unless
> > it is a test that most/all other demuxers pass I don't think it is a
> > convincing argument to make everyone fix their code (though ignore that
> > if the list is only so large because the patches I sent are not included
> > in the FFmpeg you tested).
> ill commit probetest later today, then people can add all the options they
> want to water it down, or do you want me to add some before commit?

Commit it any time, I just think that this should ideally be part of
"make test", otherwise it is too easily ignored, but too many demuxers
a) make it too easy to ignore
b) make it hard to see which ones _really_ need work

In particular the order is misleading, for example all the MTV swf etc.
show up on top although I think we haven't had even one misdetection du
to them and I doubt we will ever have one (because people usually try to
use FFmpeg on media files, not e.g. random text files, and even if they
do the result will be the same - it won't play), whereas the mpeg test
is a real-world issue.
As such I think the current output is a bit misleading as to the
priority of these.

More information about the ffmpeg-devel mailing list