[FFmpeg-devel] [PATCH] VAAPI/mpeg2: record s->mb_x
Tue Sep 15 11:12:49 CEST 2009
On Tue, Sep 15, 2009 at 11:11:57AM +0200, Reimar D?ffinger wrote:
> On Tue, Sep 15, 2009 at 10:48:31AM +0200, Michael Niedermayer wrote:
> > On Tue, Sep 15, 2009 at 09:41:38AM +0200, Gwenole Beauchesne wrote:
> > > This patch fills in the new VAAPI slice_horizontal_position field. It's
> > > needed for the Intel G45 driver.
> > >
> > > Upstream libVA GIT (0.31) is needed, or one of the 0.31 versions I provide
> > > here: <http://www.splitted-desktop.com/~gbeauchesne/libva/>
> > >
> > > Should I add a compile-time version check? e.g.
> > > #if VA_CHECK_VERSION(0,31,0)
> > > // fill in the new field
> > > #endif
> > if you are willing to maintain such code ...
> I don't see a point in supporting old versions of what I think is beta
> code which nobody really uses.
the point would be debugging, like a hypothetical
"hmm didnt that work with the previous VA version, did my ffmpeg or
VA update break it?"
that said, iam perfetly fine with just supporting the latest if noone
wants to maintain that ...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel